search

ADSP-EcoTrekker-Project / EcoTrekker

3 stars 1 forks source link

feat: Integrate Vehicle Consumption Service into Co2 Calculator #48

Closed Andy3189 closed 10 months ago

Andy3189 commented 10 months ago

@lierseleow its ready for a pr right?

lierseleow commented 10 months ago

I had pushed some changes and re-requested the review. I will also do one tomorrow.

arslanerdemm commented 10 months ago

I had pushed some changes and re-requested the review. I will also do one tomorrow.

Have you seen my suggestions regarding the objectmapper, response objects and making some attributes private? :P

lierseleow commented 10 months ago

I had pushed some changes and re-requested the review. I will also do one tomorrow.

Have you seen my suggestions regarding the objectmapper, response objects and making some attributes private? :P

Yes! And I agree. I only switched the requests to other services from WebClient to FeignClient, so all your comments regarding other changes are still relevant.

I can also implement some of them tomorrow.