search

ADVRHumanoids / ROSEndEffector

ROS End-Effector package: provides a ROS-based set of standard interfaces to command robotics end-effectors in an agnostic fashion
Apache License 2.0
27 stars 6 forks source link

Move msgs and srv to another package #19

Closed torydebra closed 4 years ago

torydebra commented 4 years ago

Should we create a new rosee_msg package instead having msg and srv folders in the main package?

liesrock commented 4 years ago

Fully agree with you: I will create a repo and the related dependencies on the main ROSEndEffector package

torydebra commented 4 years ago

If useful, I already init the package with msg for gui: https://github.com/torydebra/rosee_msg

torydebra commented 4 years ago

I transfer the msg repo from my personal github to ADVRHumanoids, now the new link is https://github.com/ADVRHumanoids/rosee_msg/

It already contains the msg that are also in this repo

liesrock commented 4 years ago

Thanks @torydebra : the repo is ok! The only issue now is to adjust the documentation with the new workflow (we need to download also the new repo which is now a dependency) and the Travis config.

I will take care of the Travis, can you update the documentation? If everything is ok I will close this issue later.

torydebra commented 4 years ago

I have already adjusted the doc update: it is in the devActions branch readme and so included in the pull request #18

torydebra commented 4 years ago

Very important to remember to select a particular branch when cloning this main repo but also the other "support" ones. This because ofter the master is not the newest one. I add this in readme (f45fa0fa73acf02cf183ad1d85a07327f1a878c6)

liesrock commented 4 years ago

Thanks @torydebra, we usually use the YCM superbuild to solve the above problem, but we should investigate how to solve it using a ROS-based build system.

liesrock commented 4 years ago

I fixed with my latest commit (ba4bad8cce9f24d8028ecafc4cb0ac50b0e96e98) also some old msg issues. I am testing the new travis config.

liesrock commented 4 years ago

OK solved everything: https://travis-ci.org/github/ADVRHumanoids/ROSEndEffector/builds/663169633

torydebra commented 4 years ago

I reopen it to ask if now it is safe to delete msgs folder in this package

liesrock commented 4 years ago

Yes, in this commit https://github.com/ADVRHumanoids/ROSEndEffector/commit/ba4bad8cce9f24d8028ecafc4cb0ac50b0e96e98

If I forgot to delete the msgs folder please do it.

torydebra commented 4 years ago

done 30794fcad6325a98727116851b8ed02064913e62

liesrock commented 4 years ago

Thanks!