search

ADVRHumanoids / ROSEndEffector

ROS End-Effector package: provides a ROS-based set of standard interfaces to command robotics end-effectors in an agnostic fashion
Apache License 2.0
27 stars 6 forks source link

Change Name to MoreTips primitive #26

Closed torydebra closed 4 years ago

torydebra commented 4 years ago

I do not like so much the name ActionMoreTips, for the action that move MORE than one TIPS with a single joint. It is confusing. I want to change it into ActionSingleJoint or something like that. With this name the user easy remembers that the key for this kind of primitive is a string containing the joint name which moves the more tips. Any better suggestions @liesrock ?

liesrock commented 4 years ago

Sorry I miss this: I would call it ActionSingleJointMultipleTips Even if this looks long, it is probably more intuitive to understand for the user.

torydebra commented 4 years ago

Right, I will change the name to ActionSingleJointMultipleTips

torydebra commented 4 years ago

Done in 6209d4bfd2321f180ce114b2780240f3af8f18f5 . Changes are on rosAction branch and will be included in devel with the pull request #28