search

ADVRHumanoids / ROSEndEffector

ROS End-Effector package: provides a ROS-based set of standard interfaces to command robotics end-effectors in an agnostic fashion
Apache License 2.0
27 stars 6 forks source link

Use fingers names as keys for actions and not fingertips names #45

Closed torydebra closed 4 years ago

torydebra commented 4 years ago

I usually speak about fingers but in truth the code still uses fingertips names. Using finger names is better because it is easier to change that name (because of srdf file)

torydebra commented 4 years ago

This was not so straightforward to do as I expected. So I created the pull request to easily check the modifications if it is necessary in future. Now is safe to merge, I tested it

liesrock commented 4 years ago

Ok, I checked it: if the documentation is updated with the above, I will merge.

torydebra commented 4 years ago

I close, @liesrock merged