ADVRHumanoids / ROSEndEffector

ROS End-Effector package: provides a ROS-based set of standard interfaces to command robotics end-effectors in an agnostic fashion
Apache License 2.0
27 stars 6 forks source link

Rate of Universal ROSEE should comes from ROS param server #5

Closed liesrock closed 4 years ago

torydebra commented 4 years ago

also the yaml name in p.init ( ROSEE::Utils::getPackagePath() + "/configs/two_finger.yaml" ); should be better to be an addtional ros param in roslaunch file (so we don't have to change the name here when other launch file is launched). I already did this, I can do the same for the rate

liesrock commented 4 years ago

Thanks @torydebra, in the latest master a pushed this morning should be as you described: can you confirm it?

torydebra commented 4 years ago

Sorry, I did not see that commit. I had put the param in launch file inside the UniversalRos node `

</node>`

but it is better to have global and take it into the parser as you did

For this issue, isn't easy? like:

ROSEE::UniversalRosEndEffectorExecutor::UniversalRosEndEffectorExecutor ( std::string ns ) : _nh ( ns ) {

    if (! _nh.getParam("/rate", _rate)){
        ROS_INFO_STREAM ("Parameter for rate not found, setting default rate of 100");
        _rate = 100.0;
    }
liesrock commented 4 years ago

yes, that's great! Please push it on a branch so we can think about some testing about it and later on if Travis CI gives the ok I will merge it.

liesrock commented 4 years ago

Merged!