EEInterface getFinger and getJoints have different "styles"

ADVRHumanoids / ROSEndEffector

ROS End-Effector package: provides a ROS-based set of standard interfaces to command robotics end-effectors in an agnostic fashion

Apache License 2.0

27 stars 6 forks source link

Closed torydebra closed 4 years ago

torydebra commented 4 years ago

In EEInterface.h we have:

const std::vector<std::string>& getFingers();
void getActuatedJoints( std::vector<std::string>&actuated_joints );

Isn't better to have a similar signature for both ? e.g.

void getFingers(std::vector<std::string>& fingers);

Maybe with both functions returing bool like the others in the class

liesrock commented 4 years ago

Solved in eb1c84aa25fab747a485ebe4a416238a94fed40b