namespace discrepancies found on hardware wrst concert_description

ADVRHumanoids / concert_description

ROS package containing modular's simulation scripts and launch files

7 stars 6 forks source link

namespace discrepancies found on hardware wrst concert_description #18

Open FraunhoferItalia opened 1 year ago

FraunhoferItalia commented 1 year ago

Hy guys!

Opening this non urgent issue with the links to the commits that include the namespace changes/discrepancies to concert_description when porting the control- as well as the navigation-ws to hardware. You can find the neccessary changes for the control-ws here and those for the navigation-ws here.

We commited the changes on a separate branch, so let us know to which namespaces you want to stick, either those present in concert_description or those we found on the hardware.

Thanks MT

EdoardoRomiti commented 1 year ago

Hi Micheal @FraunhoferItalia , with commit 5f4d0520bf7257e9112a2e852af7e033c2d72a85 of modular and commit https://github.com/ADVRHumanoids/concert_description/commit/610d8574594f95b6ad09a50f5575243088324378 of concert_description this should be fixed. Next time on the robot you should be able to use the same namespaces as in the simulation. Thanks for the catch!