ADataDate
commented
6 years ago Hey Andy! Thank for the review. I've got some reasoning behind most of this stuff. See comments in line below and let me know if my design implementation makes sense. Thanks!
D+ and D-, have you tested these to make sure theyve got the same impedance? Might be better to rotate the SAMD21 180 degrees but thats a lot of rerouting.
The total length of those traces provide a negligible amount of resistance.The board is actually much smaller than it looks in Eagle. Angela can show you a cut-out if you haven't seen it already.
DI is mislabelled on the left neopixel wing. Speaking of labelling the neopixel wings, I think it might be a better idea to label them with the corresponding data pin instead of DI, as otherwise people will have to trace the traces back to find out which data pin they need to write to.
UPdated the label. I do not want to label the DI/DO pins with the digital pin on the MCU because once the kit is broken apart I don't want people to think they can only hook it up to one PWM pin on the SAMD21.
Net N$8 is unlabelled and also doesn't connect tot anything? perhaps pointing out that this is a thru connection or something, or even just getting rid of it, idk what i'd use it for after popping the board apart, but if you have a reasoning behind it, go ahead and keep it, I think it should definitely be labelled.
Yes, it is a "passthrough" I plan on implementing whole boards that are just passthroughs to make wiring prettier.
via between C21 and D33 seems to be misplaced I'll be looking into this tonight
*D9 signal gets a little wonky while exiting the right LED wing. Those traces have been updated
Labels could be more consistent (Centered over the pad with the bottom of the label facing the pad) Angela's working this
label reset button? Done
many traces have extra little kinks, might be worth cleaning up some of the angle errors (Also the angle errors might be what's causing your crashes, I've had similar issues with angle errors) hmm, maybe I should move to curvy traces like LilyPAd? I'll checkout tonight. Although, Eagle was crashing before I even started routing**
Label VIN switch? Yes
Relabel VCC to 3V3? Idk I just like it better the whole thing will be a 3.3V system and I don't want people thinking they can hook a one of their own 5V sensors later on.
I've got some notes!
D+ and D-, have you tested these to make sure theyve got the same impedance? Might be better to rotate the SAMD21 180 degrees but thats a lot of rerouting.
DI is mislabelled on the left neopixel wing
Speaking of labelling the neopixel wings, I think it might be a better idea to label them with the corresponding data pin instead of DI, as otherwise people will have to trace the traces back to find out which data pin they need to write to.
Net N$8 is unlabelled and also doesn't connect tot anything? perhaps pointing out that this is a thru connection or something, or even just getting rid of it, idk what i'd use it for after popping the board apart, but if you have a reasoning behind it, go ahead and keep it, I think it should definitely be labelled.
via between C21 and D33 seems to be misplaced
D9 signal gets a little wonky while exiting the right LED wing
Labels could be more consistent (Centered over the pad with the bottom of the label facing the pad)
label reset button?
many traces have extra little kinks, might be worth cleaning up some of the angle errors (Also the angle errors might be what's causing your crashes, I've had similar issues with angle errors)
Label VIN switch?
Relabel VCC to 3V3? Idk I just like it better