AE2-UEL / Applied-Energistics-2

AE2UEL, a Fork of a Minecraft Mod about Matter, Energy and using them to conquer the world.
https://legacy.curseforge.com/minecraft/mc-mods/ae2-extended-life
Other
74 stars 71 forks source link

Soft Crash whenever attempting an autocrafting order from an Arcane Crafting Terminal #418

Closed thegenghistkhan closed 4 months ago

thegenghistkhan commented 5 months ago

Describe the bug Whenever I attempt to put through an autocrafting order from an arcane crafting terminal, my game soft crashes. The prompt to select the number of items to autocraft pops up, but when I hit next, the game soft crashes before the next prompt showing the items to be crafted shows up.

To Reproduce

  1. Open arcane crafting terminal
  2. Select an item to autocraft
  3. Select any quantity and hit next
  4. Game then soft crashes

Expected behavior The next prompt showing the "items to be crafted" and then clicking the start button.

Additional context 2024-04-18_20 29 18 2024-04-18_20 29 22 2024-04-18_20 29 33

Crashlog: https://mclo.gs/Y2XPEgT

Environment Minecraft: 1.12.2 Forge: Mod Loader: 8.0.99.99 Applied Energistics: AE2 Unofficial Extended Life v0.56.4 Thaumcraft: 6.1.BETA26 Thaumic Energistics: 2.2.7 Modpack: The 1.12.2 Pack

Delfayne commented 4 months ago

This is due to the way ThE reaches into the number box to get the crafting amount. I've already been looking at a fix this morning, so I wouldn't worry too much. Actually your fix already builds on top of a change I made in the same area to fix something else. The previously released code would still have failed here, though slightly differently.

What this means is that 0.56.0+ will break previous versions of ThE when trying to craft arcane items. Since we'll have a fix out, this might be "fine", but you may want to doc it.

A compatible fix would probably be to let ThE reach into GuiCraftAmount#amountToCraft (with an accessor method) so we don't have to use reflection/mixin it. Better yet, extract the logic from actionPerformed that parses the expression, then we'll use that.

Delfayne commented 4 months ago

I have created a build with fixes for this and others. Please let me know if there are any issues. I will push out to CF at the weekend https://github.com/Delfayne/ThaumicEnergistics/releases/tag/v2.3.0

mczph commented 4 months ago

Confirm fixed