search

AECX / FinTube

Jellyfin Plugin to import directly from YT
124 stars 11 forks source link

Fix APIs authorization #13

Closed vincentroyc closed 2 months ago

vincentroyc commented 5 months ago

Authorization were not working anymore with the latest release of Jellyfin server

Fixes this issue : https://github.com/AECX/FinTube/issues/10

lamebread commented 4 months ago

no idea how many different AuthorizationPolicies exist, but 'Administrator' sounds a bit too overpowered, no? seems weird that a plugin gets admin privileges just to download videos and put them into libraries.

vincentroyc commented 4 months ago

no idea how many different AuthorizationPolicies exist, but 'Administrator' sounds a bit too overpowered, no? seems weird that a plugin gets admin privileges just to download videos and put them into libraries.

Unless I misunderstand how it works, the plugin doesn't get administrator privileges. It requires the user to have admin privileges to use it though.

Tukajo commented 3 months ago

I agree w/ @lamebread that there should be an alternative to providing a third party plugin with administrative privileges.

Is it not possible to allow a user to perform this action?

I guess there is no UI for a user to import media today anyway. So it is sort of "always" an administrator performing this action, so maybe it is ok.

Tukajo commented 3 months ago

Thinking about it more... I feel like the use-case here is: Does the instance owner prefer to have admins be the only ones to upload media from YouTube or do they prefer that all users are capable of this.

I think this is "fine" as an approach honestly for now, given that this plugin is only accessible via the Admin page anyway. But in a future iteration one could imagine a separate portal for users that are non-admins to use this.