Open cnlohr opened 8 months ago
Do you mean like lighter touches should be registered?
No, this is for wifi. Just adjusting the power and IGI muting.
Will revisit when there are hotdog prototypes
As a note for the future, the lines that matter are:
// Appears to set gain "offset" like what it reports as gain? Does not actually impact real gain.
// But when paired with the second write command, it seems to have the intended impact.
// This number is in ~1/2dB. So 20 accounts for a 10dB muting; 25, 12.5dB; 30, 15dB
const int igi_reduction = 20;
and
wifi_country_t usa = {.cc = "USA", .schan = 1, .nchan = 11, .max_tx_power = 84, .policy = WIFI_COUNTRY_POLICY_AUTO};
My current feeling is we should keep IGI reduction the same, but increase power by a smidgen, but we need to understand the units of max_tx_power
since I didn't document it, and the official documentation is inscrutable. https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/network/esp_wifi.html#_CPPv425esp_wifi_set_max_tx_power6int8_t
Wait, it looks like we are commanding max power??? I thought we were muting. I wonder if there is muting code elsewhere I am unaware of. Our comments mention wifi_set_user_fixed_rate
- perhaps it was a previous version?
I lost the tread on wifi a while ago, but I did try to turn the power up all the way when doing the initial IDF setup.
aaahh https://github.com/AEFeinstein/Super-2024-Swadge-FW/blob/main/sdkconfig#L826-L828
CONFIG_ESP_PHY_MAX_WIFI_TX_POWER=20
CONFIG_ESP_PHY_MAX_TX_POWER=20
CONFIG_ESP_PHY_REDUCE_TX_POWER=y
CONFIG_ESP_PHY_RF_CAL_PARTIAL=y
Ok, we will have to investigate.
Just a TINY bit, like ONE notch. It's just toooooo restrictive it seems.
This is a note for @cnlohr for the future.