search

AEGEE / oms-core-first

[DEPRECATED] Core module of the online membership system of AEGEE.
Other
5 stars 5 forks source link

Add gjslint task for more style checks and apply most suggestions #25

Closed ingomueller-net closed 8 years ago

ingomueller-net commented 8 years ago

This adds more linter tasks using gjslint.

I applied most improvements suggested by the tool, but long lines should still be broken into shorter ones. I'll leave that task to you, @serviceman ;) Also I deactivated complaints about missing documentation. Having documentation would be great though! Since I am not too sure whether we want the format of documentation that gjslint expects, I currently deactivated this check.

ingomueller-net commented 8 years ago

OK, the tests still fail now, but unlike my first attempt (pull request #24), this is because gjslint is unhappy about too long lines. The tests are running as intended though :)

@serviceman, can you fix the long lines?