search

AEGEE / oms-core-first

[DEPRECATED] Core module of the online membership system of AEGEE.
Other
5 stars 5 forks source link

Add gjslint task for more style checks and apply most suggestions #26

Closed ingomueller-net closed 8 years ago

ingomueller-net commented 8 years ago

Add even more style checks on top of pull request #25: check json files for validity and more options for jshint.

linuxbandit commented 8 years ago

this is just like #25 with 3 more commits....? I am surprised, I thought github automatically would put all the branch commits as part of the same PR? which is what I was referring to in my comment in #28 ("if it depends on a PR, then why don't you merge it in the branch of the PR you refer to? This way it will be part of the same PR" - or at least I thought)

ingomueller-net commented 8 years ago

Yes, I should have done the PRs from the same branch.

Haha, now I see that Github even tells me that: "Add more commits by pushing to the grunt-closure branch on ingomueller-net/oms-core."

linuxbandit commented 8 years ago

yes, but both PRs are coming from the same branch, thus you must surely have pushed onto the same! No?