search

AEGEE / oms-core-first

[DEPRECATED] Core module of the online membership system of AEGEE.
Other
5 stars 5 forks source link

Add unit tests with mocha #28

Closed ingomueller-net closed 8 years ago

ingomueller-net commented 8 years ago

This PR should be added on top of pull request #26.

linuxbandit commented 8 years ago

Then why don't you merge it in the branch of the PR you refer to? This way it will be part of the same PR On 20 Nov 2015 11:33, "Ingo Müller" notifications@github.com wrote:

Assigned #28 https://github.com/AEGEE/oms-core/pull/28 to @serviceman https://github.com/serviceman.

— Reply to this email directly or view it on GitHub https://github.com/AEGEE/oms-core/pull/28#event-470229807.

ingomueller-net commented 8 years ago

I don't know, it's your call. You should merge in my PRs, no? If you accept all changes, then just merge in this PR and I'll close the others...

linuxbandit commented 8 years ago

Sorry for the late answer, I meant to say that maybe if it has another PR as requirement it should be still part of the same PR (i.e. changeset)?

ingomueller-net commented 8 years ago

Yes, that's what I thought as well. I just learned how I should have done it: update the same branch I created the PR from (see this post).

So, any comments or requests for change before you can merge?