Progress towards Python 3.12 support

AEI-ACR / pygsl_lite

A minimal wrapper for GSL based on the pygsl library

GNU General Public License v2.0

1 stars 1 forks source link

Progress towards Python 3.12 support #2

Closed SergeiOssokine closed 6 months ago

SergeiOssokine commented 1 year ago

Python 3.12 brings some forced deprecation:

imp module is gone
numpy.distutils is gone Fortunately we only used the former to locate Numeric which at this point we can assume will not be used (long live numpy). For the latter we just needed to get the numpy includes.

Note that pyseobnr upstream is blocked by numba compatibility issues

SimonMaenaut commented 6 months ago

Dear developers, Is there anything I could help with to get this branch merged for a new release? Since the issues with numba are resolved, I was able to use this branch. However a new pipy release with this fix would be great. Kind regards, Simon

raffienficiaud commented 6 months ago

Hi @SimonMaenaut and @SergeiOssokine , please give me a couple of days and I look into this.

github-actions[bot] commented 6 months ago

Unit Test Results

5 files 5 suites 0s :stopwatch: 1 tests 1 :heavy_check_mark: 0 :zzz: 0 :x: 5 runs 5 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 8c1260ad.

:recycle: This comment has been updated with latest results.

raffienficiaud commented 6 months ago

@SimonMaenaut I added compilation checks for all supported versions of python and it seems to work ok. Would you please give a try on the current branch?

SimonMaenaut commented 6 months ago

@raffienficiaud Thank you for resolving this so quickly!

Since there is already a new release, I installed it from pipy through pip and everything works for me as expected.

raffienficiaud commented 6 months ago

@SimonMaenaut perfect and thanks for the feedback. All the credit goes to @SergeiOssokine