AEMBOT / frc-2018-summer-project

6443's robot code for 2018 Summer Project
1 stars 2 forks source link

moved pixy class from subsystem to hardware #8

Closed LizzyMilford closed 6 years ago

LizzyMilford commented 6 years ago

and incorporated pixy into shooter and turret

LizzyMilford commented 6 years ago

Please look over this and the changes that I made. I think having the Pixy as hardware makes more sense and actually fixes a few errors I found (such as creating a new instance of Turret class. We should only ever be working with one instance of subsystem classes, hence making them all static finals in Robot.java). If you are confused or disagree with any of my thinking make sure to talk with me about it and maybe we can find a different solution. Personally, this seemed like the easiest and most logical way of doing it, but I'm sure there are many other ways of tackling the problem.

LizzyMilford commented 6 years ago

Added a second commit allowing the pixy to return the angle of the object. This makes it so that all movement occurs in the turret class (ie: no consumer necessary). There are still a few questions that I asked you and I will make another commit to fix those when you respond.