Code Changes

[Elix-x]

This is issue for all changes that have to be done in code. Mainly, by me or @JosephRymer.

In code, we now have //TODO 1.10-R tags which mean that whatever has to be done there, appeared during this port. When thing is done, remove the tag. @JosephRymer this basically allows us to communicate in code what to do, if we, for example, didn't finish it. You can also leave those (and i will do them whenever i can). If you want somebody specific to do it, add @ tag (after 1.10-R referencing him).

Any questions concerning those tags go here.

[StrayCargo]

alright nice to know

[Elix-x]

I just noticed that AE uses deprecated IInventory and ISmartInventory. Should be moved to capabilities.

[StrayCargo]

ok well i am currently digging the code im beginning to think we should just rewrite it ti be a little less old code and get it up to speed and try to make it open so it can accept MCMP or FMP easier if one becomes the other or a new one is developed allowing for modules like FMP to be coded in easier in essence leaving some open ends for future expansion as well as i wont be able to do much this week but i will do my best to try and get a commit in this week i hope currently working on Biomettric card model testing the difference to see which is working better and if the 2 will play with each other or if they dont like it Leave me some feedback @elix-x and @dpeter99

[Elix-x]

If you want, you can leave multipart system to me. I can look into it. As to should we rewrite it - no. When time will come, we will integrate it / support FMP. For now, it "works" tm, and we should leave it as it is (server side, rendering has to be redone).

Meanwhile, we need animated models for some things. (As i already said), it requires work on both sides, so someone of us should work with @dpeter99 on those.

[Elix-x]

Found even more things to do server-side, here's full list:

• [ ] Move inventory implementations to caps. Interfaces are deprecated. Class hierarchy affected: ? extends AEInventoryTile.
• [ ] Fix rotations and other properties not being saved. Includes both blocks (meta -> state -> meta) and tes (read/write NBT). Class hierarchy affected: ? extends AEBaseBlock | AEBaseTile.
• [ ] Check & fix not working containers & client GUI counter parts. Some are working and some are not.

If somebody is willing to do it, go ahead. I will not be able to do any of these any time soon (i'm busy with model baking pipeline).

[StrayCargo]

@elix-x don get burned by that bakery but ill be looking into the inventory GUI texture failure

[Elix-x]

Ok, thanks. I'll try not to.

[Elix-x]

I recently got to server side testing with parts and stuff (don't ask how ;) ), and... Yeah:

• [ ] All network stuff still not ported to 1.8's multi threaded net. (Tons of async exceptions in logs)
• [ ] Due to it and more things, sync is broken. Completely.
• [ ] ME system works... Kinda... It can store items, import and export them, but crafting does not work and contents aren't synced to client. Also breaking (nearly) any full block ME machine (while part of grid) crashes MC.

[Elix-x]

Ok, one more thing i was forgetting to put here for long time:

• [x] (https://github.com/AEModernMCPort/Applied-Energistics-2/commit/dc7ddfe107089420f3d608d87ff47ee822477989) Stairs don't need their own FeatureHandler, merge with block's.

[StrayCargo]

Well currently had the texture for the 4k storage working and now its no longer working so im going to jump to something else since models seem to be so funky. Anything specific you want me to look at @elix-x

[Elix-x]

I merged stairs already, so you may look into syncing and all that stuff... And try not to break it :D.

[StrayCargo]

ahh ok

[StrayCargo]

well im going to continue to look into models

[ThomasSaunders]

I'm happy to start looking through the code issues, as I cannot model to save my life, and code is where I live @elix-x @JosephRymer , what is the highest priority?

[Elix-x]

Well, all things with check marks are things to do. If you're good with net & netty & packets, you may want to work on synchronization (consider that it is a big chunk of work).

[ThomasSaunders]

I'll start working on that then @elix-x .

[Elix-x]

Thanks!

[StrayCargo]

@elix-x @biggles2206 @dpeter99 I know this should be in Status updates but here is better. I have been doing serious looks over all of AE2 code for 1.7.10 and are port to 1.10.2 and realized some serious issues. we are ignoring classes that should not be ignored causing issues with stairs and not to mention the model creation is a mess of 2 different styles of models. We also have TODO tags with nothing mentioned in them for what needs to be done. Lots commented out code that out of date and overall formatting issues across the code. These need to be fixed but more or less I have begun the process of cleaning the code and trying fix some these TODO taged issues. I am saying this because I am hoping that we can maybe come up with a solution for porting to 1.10 instead of the one we have now .

[ThomasSaunders]

@JosephRymer that sounds sensible. I have a 2 hour flight ahead of me now so I am happy to clean up code if that would be helpful.

[Elix-x]

We also have TODO tags with nothing mentioned in them

Blame pre-1.8 (aka original main AE team). Everything (almost) that concerns porting is tagged with 1.10-R/1.10.2-R and has description.

Lots commented out code that out of date

I (and apprently AE team) usually code out crucial code in case things go wrong... And when it works forget to remove it.

overall formatting issues across the code

= All PRs + formatting inconsistency. Although i agree, that it should be reformatted correctly.

mess of 2 different styles of models

Will be 4 or 5 with arrival of cables :D ...

[ThomasSaunders]

@elix-x @JosephRymer Do you want me to clean up code/Todo Tags ect or start ironing out the broken code that needs updating?

[Elix-x]

Well, important to-do tags are duplicated here (and 50% of them are balming broken syncing). All broken code has to-do tags next to it. So, well, it's kinda similar.

Meanwhile old commente uneeded code is not marked with todos or here. And there's quite a bit of it. (Especially old mod integration code. In theory, will have to be rewritten any way).

While you're here, please don't touch multipart&cable system (mainly rendering), as i'm working on it and have already removed ~all old code.

[StrayCargo]

Heres my suggestion how about me and @biggles2206 start work on reformatting the code and leave your section alone the make a pull request to pull it to the main branch and then continue work on the TODO tags while were also formatting we would look over the TODO tags and determine of there necessary along with commented out code

[Elix-x]

Definetly! Just branch off of 1.10-rv3-rendering and then PR when you're done. Do you want me to add him to the team?

[ThomasSaunders]

I've forked the repo so I will do my work on there, if needs be I can merge it into a new branch.

[StrayCargo]

@elix-x yes i would love him a part of it

[Elix-x]

• [ ] Reorganize properties fields & classes (@shartte, post #31).
• [ ] Quartz torch mirrored property (@shartte, post #31, according to #31#issuecomment-239395781).

[ThomasSaunders]

I'm back in the UK now, so I will start organising the code now.

[shartte]

@elix-x I've re-checked the behavior in 1.7 and there is no manual mirroring of the torch. It's all based on the x,y,z position in the world (it just does a modulo 2). I've implemented exactly that behavior for 1.10 as well using a new "ODD" property I've attached to BlockQuartzTorch (using getActualState).

What else would you like me to reorganize? Move AEBaseBlock.AXIS_ORIENTATION into QuartzPillarBlock since it's used only there?

[Elix-x]

@biggles2206

• [x] Move AEBaseBlock.AXIS_ORIENTATION into QuartzPillarBlock since it's used only there

[ThomasSaunders]

@elix-x I will do that now -- EDIT -- Change completed, pull request made. #38 .

[drekryan]

Looks like on PR38 someone left a merge conflict in AEBaseBlock

[shartte]

Yeah and the property still seems to be half-present in AEBaseBlock as well.

[ThomasSaunders]

@drekryan It all seems to have merged nicely when I did it earlier. I solved the conflicts offline after Github hlighted them offline.

@shartte Seems I overlooked that in my half asleep state last night. I am fixing that now. :)

[drekryan]

@biggles2206 awesome thanks for the fix

[Elix-x]

• [ ] Models made in #48 and all related will have to be redone. Vanilla now has a way for items to use blockstate json specifications. Check bow for example. @shartte i might revert #48 and all releated, so don't freak out.

[Elix-x]

• [ ] Recipe system uses custom parser. -> GSON?