Controller Model

[shartte]

Implemented the controller models using the UVL model loader to make the lights be fullbright at night. A fix in UVLModelLoader was required (quad facing wasn't propagated and got lost along the way), since otherwise the game crashes due to the on-the-fly tile rotation.

At night:

[dpeter99]

Does the Controller base json needed?

[Elix-x]

I'll do push major changes to names & loading today or tomorrow. Changes to UVL loader will be included (line that you changed was already changed in my workspace, though i didn't push it).

[shartte]

@dpeter99 It's currently used for the offline versions of the block/column ps: To clarify, I had a base JSON for the lit controller version as well, but that doesn't currently work with the UVL loader, so I inlined it into the different models directly.

[Elix-x]

Should work after my next commit. ^{srry for the wait}

[dpeter99]

Yes but you could use the vanilla block (cube). Take a look at the vanilla stone block.

[shartte]

@dpeter99 Ah yes you are right. I didn't realize that after I refactored the models a bit. Previously every model always had the two "layers" to it. I'll investigate and amend this PR.

[shartte]

@dpeter99 Okay I have amended the PR and removed controller_base. I am now using cube_all for all unpowered variants.

[dpeter99]

For cullom ones please use different. Which can put normal texture on top/bottom.

[shartte]

@dpeter99 I don't quite follow. The controller only has one texture for all sides. If a resource pack author wants to change the look, he can always override the JSON file and move to block/cube as a parent. Should I change it anyways?

[dpeter99]

I thought parent: cube_column

[shartte]

Ah for the columns. Yeah but I don't think it really matters. You can never see the top/bottom of controller columns, since they are only used when there's another controller block on top AND bottom of the column. That's why I went with cube_all. There's also no texture for the top/bottom of controller columns.

[dpeter99]

Yes just for convenience.

[StrayCargo]

Can we push merge this pull request or is it still to early to make the merge would help me a lot in making more models later one in the future

[Elix-x]

He has problems with parents. I'll push tweaked uvlloader to support parents, then merge this and apply naming reconvention.

[StrayCargo]

cool thanks

[shartte]

@elix-x You can merge this as-is if you want. As soon as you'll update the UV Loader I'll just send another PR that refactors the individual JSONs back into a single parent.

[StrayCargo]

@shartte just amend this pr so that we can do it in one step

[shartte]

@JosephRymer I can't amend the PR until he actually commits the fix though, and I don't know when that'll be :P

p.s.: Call me paranoid. I just dont like having PRs open for extended periods of time when there's a lot of movement in general. It increases the chance for merge conflicts and thus avoidable extra work.

[StrayCargo]

ahh ok

[Elix-x]

@shartte you're responsible for fixing things when they break in 8 hours (max).

[shartte]

Awesome. If you want, we can make an issue and assign it to me. Otherwise i'll just do it once the model code comes in. On a related note: we now have a nice creative tab icon again! Woohooo!

[Elix-x]

I can assign an issue to you when you'll be in the team. And i can't (yet) put you in team?.