search

AEModernMCPort / Applied-Energistics-3-Fork

A Minecraft Mod about Matter, Energy and using them to conquer the world..
http://ae-mod.info/
Other
37 stars 12 forks source link

Fixed Particle Effect Corruption #43

Closed shartte closed 8 years ago

shartte commented 8 years ago

This fixes issue #11.

The Particle FX classes were using a different ordering for the vertex attributes than Minecraft. This caused the color to be interpreted as the position and some other funkyness. I copied the vertex attribute ordering from the Vanilla base class and did this for all the FX classes that override renderParticle.

This is how it looks now: Particle FX

They seem to look very slightly thicker than in 1.7, but that can be fixed later. In addition, the Particle FX classes definitely need some love w.r.t. to code quality, but i wanted to keep this PR small.

Elix-x commented 8 years ago

Light map is taken from vanilla i suspect.

Does it fix all particle issues?

shartte commented 8 years ago

@elix-x It fixes the light fixtures and the crystal growth accelerator for me. I couldn't test the crafter, because I don't think that works yet. I still want to double check that they are 100% working once all the items/blocks are done, but the format in which they fill the vertex buffer is now in sync with what Vanilla does.

Elix-x commented 8 years ago

Hint: you have /particle.

shartte commented 8 years ago

@elix-x That command does not work for non-vanilla particles. It uses an enum internally to map from name->particle type, which we cannot extend.

p.s.: I had to dig into CommandParticle to figure that out :P

Elix-x commented 8 years ago

That's weirdly interesting. I'll look into command part.

shartte commented 8 years ago

@elix-x I think this fix is still relevant as far as I know. Any chance of merging it?

Elix-x commented 8 years ago

So i did not merge it... Oh, i know where i got stuck.

I'll merge it, other particles will be fixed as we see them in game.

shartte commented 8 years ago

Awesome thanks. And yes, more fixes are sure to follow.