Remaining non-compliant filenames

[shartte]

I've run a short script on all files in our assets:

Checking resource filenames in C:\projects\ae2\src\main\resources\assets
Filename contains invalid characters: \appliedenergistics2\lang\cs_CZ.lang
Filename contains invalid characters: \appliedenergistics2\lang\de_DE.lang
Filename contains invalid characters: \appliedenergistics2\lang\en_GB.lang
Filename contains invalid characters: \appliedenergistics2\lang\en_US.lang
Filename contains invalid characters: \appliedenergistics2\lang\es_ES.lang
Filename contains invalid characters: \appliedenergistics2\lang\fr_FR.lang
Filename contains invalid characters: \appliedenergistics2\lang\hu_HU.lang
Filename contains invalid characters: \appliedenergistics2\lang\it_IT.lang
Filename contains invalid characters: \appliedenergistics2\lang\ko_KR.lang
Filename contains invalid characters: \appliedenergistics2\lang\pt_BR.lang
Filename contains invalid characters: \appliedenergistics2\lang\ro_RO.lang
Filename contains invalid characters: \appliedenergistics2\lang\ru_RU.lang
Filename contains invalid characters: \appliedenergistics2\lang\zh_CN.lang
Filename contains invalid characters: \appliedenergistics2\lang\zh_TW.lang
Filename contains invalid characters: \appliedenergistics2\models\block\cube\cube_AE _all.json
Filename contains invalid characters: \appliedenergistics2\models\block\cube\cube_AE.json
Filename contains invalid characters: \appliedenergistics2\models\block\cube\cube_AE_bottom_top.json
Filename contains invalid characters: \appliedenergistics2\models\block\cube\cube_AE_machine.json
Filename contains invalid characters: \appliedenergistics2\models\block\EnergyCell
Filename contains invalid characters: \appliedenergistics2\recipes\network\blocks\crystal-processing.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\blocks\spatial-io.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\cells\spatial-components.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\cells\storage-components.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\parts\cable-anchor.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\parts\io-buses.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\parts\quartz-fiber.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\network\parts\toggle-buses.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\README.html
Filename contains invalid characters: \appliedenergistics2\recipes\tools\certus-quartz.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\tools\matter-cannon.recipe
Filename contains invalid characters: \appliedenergistics2\recipes\tools\nether-quartz.recipe
Filename contains invalid characters: \appliedenergistics2\textures\guis\craftAmt.png
Filename contains invalid characters: \appliedenergistics2\textures\items\White.png
Filename contains invalid characters: \appliedenergistics2\textures\orientation\BlockMatrixFrame.png
Filename contains invalid characters: \appliedenergistics2\textures\orientation\BlockMatrixFrameBack.png
Filename contains invalid characters: \appliedenergistics2\textures\orientation\BlockMatrixFrameBottom.png
Filename contains invalid characters: \appliedenergistics2\textures\orientation\BlockMatrixFrameEast.png
Filename contains invalid characters: \appliedenergistics2\textures\orientation\BlockMatrixFrameFront.png
Filename contains invalid characters: \appliedenergistics2\textures\orientation\BlockMatrixFrameWest.png

[Elix-x]

And what is considered invalid character?

[shartte]

def filenamePattern = ~/[a-z_0-9]+(?:\.[a-z]+)*/;
def directoryPattern = ~/[a-z_0-9]+/;

That seemed like the convention you came up with in #46

[Elix-x]

Actually, i used /[\p{Lower}|_]*/.

Yay, you use groovy too :smile: !

[yueh]

It should actually be /[\p{Lower}|\p{Digit}|_]*\.json/ my sonarqube instance is also already complaining about it.

I could already run it against PRs and let it report. But it can get a bit noisy like here

[shartte]

I don't think only allowing .json is sufficient.

This was a quick first check. It should actually check a lot more (i.e. references). Another check it could do is check [blockstate/models/textures] for their respective file types and report incorrect extensions.

[yueh]

It is json specific. So it will also report invalid syntax, missing newline and such things.