Implemented registry renaming as discussed in #70

AEModernMCPort / Applied-Energistics-3-Fork

A Minecraft Mod about Matter, Energy and using them to conquer the world..

http://ae-mod.info/

Other

37 stars 12 forks source link

Implemented registry renaming as discussed in #70 #89

Closed shartte closed 8 years ago

shartte commented 8 years ago

This renames the block registry names as discussed in #70.

I think to split up the discussion from there, if this is okay or not should further be discussed here.

In this PR, I chose to go with "quartz" instead of "certus quartz" for two reasons:

It's namespaced to our modid
We would have to rename things like the pillar block and everything else that currently is only named quratz_* to certusquartz*

I've also renamed the API accessors to match the registry names more closely and renamed the affected blockstate files.

Elix-x commented 8 years ago

But should we shorten "access point" to "ap" or not?

@yueh...

shartte commented 8 years ago

wireless_access_point is quite long, but I would be okay with it, if yueh also agrees. I just find it important that it's not simply "wireless" without any qualifiers, as it was before.

Elix-x commented 8 years ago

Yes, wireless is even worse.

shartte commented 8 years ago

I updated the PR:

wireless -> wireless_access_point
skystone -> sky_stone
Skystone -> SkyStone (w.r.t. field names)
chiseled_quartz -> chiseled_quartz_block
smooth_skystone -> smooth_sky_stone_block

yueh commented 8 years ago

But otherwise it looks fine.