search

AEModernMCPort / Applied-Energistics-3-Fork

A Minecraft Mod about Matter, Energy and using them to conquer the world..
http://ae-mod.info/
Other
37 stars 12 forks source link

Replaced Guava's Optional #90

Closed shartte closed 8 years ago

shartte commented 8 years ago

As discussed in #81.

This was more work than I thought initially, but it's completely replaced now.

shartte commented 8 years ago

Implemented code review suggestions. Will do another rebase.

yueh commented 8 years ago

Btw. these are just suggestions. If you think it is bullshit, just say it.

shartte commented 8 years ago

Oh no, they made the code better in my opinion, and I am absolutly thrilled about good code reviews :+1: . I did the "something fancy" suggestion a bit differently however :)

yueh commented 8 years ago

I have the tendency to abuse higher order functions a bit when I can. It is not that bad with Java as it is quite verbose.

But my scala code can easily look like val stuff = collection zipWithIndex filter predicate collect { case Foo(bar, _, _) => bar.baz } map square reduceLeft (_ + _)

shartte commented 8 years ago

@elix-x I rebased this branch onto the restructuring branch again after the last PR that was merged. Do you have any objections to merging this?