Closed Elix-x closed 7 years ago
@yueh your opinion?
Semver does not really fit the current version scheme.
rv2 to rv3 would pretty much be a minor change, there were no real API breaks. In the same way builds can either be a minor or patch version.
The alpha/beta/stable cycle also does not really fit well with semver. This would pretty much be something like rv3 beta b10 -> 3.0.0-0.10.x
I would encode it as 3.0.0-beta.10 for example
Which pretty much defies semver as we pretty much ever use x.0.z. The minor version would be pointless.
Semver for minecraft mod is literally stupid. The idea behind semver is for dependencies and their management so it is easy to fetch bugfixes without adding any incompabilities. There are simply no dependencies who could make use of it. Without unit tests it is also a bit pointless to risk a release as even a patch could result in an API break.
Nevertheless major would fit for rv, and minor and patch could be splitted builds (by fixes and new features). Just the alpha/beta cycle does not fit well. What would semver say about something like rv.build.fix-channel?
Btw. if the gradle file should also use major.minor.patch-prerelease as names. aeversion
should also be 0.
And I have to talk with algo about it. I am not sure, if the deployment process would even support it.
Semver
x.y.z
)x
is more important then y
which is more important then z
(we can make a bug fix and increment x
, but can't make a game breaking feature and increment z
) (eg: when y
is incremented, z
is reset to 0).-
at the end (-alpha
, -release
).x
, y
and z
for, as long as we follow p2.@yueh
rv.build.fix-channel
(TLDR) Possible.
I know it is possible. But would players be able to recognise it. (Note, they are even too stupid to read a calendar date)
Well, majority wants us to move to semver. Though it's not as big split as going java 8 vs going java 7.
Or just one bot might want it.
Maybe. But that's the only source of this kind of information about players playing AE we have.
@yueh So what was algo's answer?
Made versioning fully conform to semver. Added minor ae version (required for semver).
Examples (in examples minor version is unused):