search

AEModernMCPort / Applied-Energistics-3-Fork

A Minecraft Mod about Matter, Energy and using them to conquer the world..
http://ae-mod.info/
Other
37 stars 12 forks source link

fix localization and block models #98

Closed qwerty123443 closed 7 years ago

qwerty123443 commented 8 years ago

these commits fix the localization files and block models. note that not all the block models are final, as orientation is currently broken. there also were some textures missing. the console still complains about missing textures which are not actually missing (not sure what's going on there)

Elix-x commented 8 years ago

Other than that, this looks good. I'll merge once we finish restructuring.

StrayCargo commented 8 years ago

we dont need this commit intellij setup was working before this change so it should work without it

Elix-x commented 8 years ago

We don't need intellij part. But we need this PR.

qwerty123443 commented 8 years ago

fixed. I was unable to remove the newline from the drive blockstate, intellij says there is no newline there

qwerty123443 commented 8 years ago

switching to this branch broke some of the localization. should I fix it for this branch or leave it like this so the rendering branch gets the good localization?

Elix-x commented 8 years ago

Eventually, restructuring will be merged into rendering (that's why i asked you to switch branches in the first place). So...

qwerty123443 commented 8 years ago

i'll fix it for this branch then

qwerty123443 commented 8 years ago

fixed

Elix-x commented 8 years ago

Nice!

StrayCargo commented 8 years ago

I agree

We don't need intellij part. But we need this PR.

qwerty123443 commented 8 years ago

I removed the intellij stuff in the second to latest commit

StrayCargo commented 8 years ago

@elix-x can you look at this and confirm its good to go looks good to me

Elix-x commented 8 years ago

@JosephRymer :| look 3 comments above... image