AEModernMCPort / Applied-Energistics-3-Fork

A Minecraft Mod about Matter, Energy and using them to conquer the world..
http://ae-mod.info/
Other
37 stars 12 forks source link

Modusep #99

Closed Elix-x closed 7 years ago

Elix-x commented 8 years ago

From discord: Alright, i pushed https://github.com/AEModernMCPort/Applied-Energistics-2/commit/45cbbae073efef0155f92b219f129f8584b043de

What you have to do is marked with //TODO 1.10.2-MODUSEP First, deal with todo tags, then with logger. And then actually move stuff from core module to their respective modules. Notes:

And you did commit everything, right? ;)

@biggles2206 @JosephRymer please work on this. I'll be working on this too when i have time. When you commit, reference this issue (relates to #99). This is the highest priority right now.

StrayCargo commented 8 years ago

@elix-x i have looked and have realized that some of the TODO tags dont contain any comments so i dont know what to do there can you double check the TODO and take any out that are empty

Elix-x commented 7 years ago

@JosephRymer these tags are from pre-1.8 time. Ignore them for now.

StrayCargo commented 7 years ago

okay thanks

JelmarG commented 7 years ago

I thought it was decided not to make AE2 modular? I also think @yueh was against it? I still don't understand how a modular AE2 is beneficial to the end-user, like, at all. It will only make downloading/installing the mod needlessly confusing. I must have missed something.

Elix-x commented 7 years ago

@JelmarG We "changed" meaning of "module" (if that makes sense). Modules are internal hierarchy that allows us to work on AE together easier, with less conflicts. Meanwhile, yueh was suggesting putting decorations (and tools) into different mod. At first he was, then he was not, then he was... So the path that we took is making decorations, tools & misc external modules. BUT the entire jar (or bundle) will stay and it will be the main jar. If users don't want misc for example, then they can download external modules one by one (because there are only 4 "external" modules and ~10 "internal" or submodules that can't be split into different jars), and for that, they will have to look a bit deeper.

JelmarG commented 7 years ago

Okay, so at least it won't be confusing for the end-user.