AERPAW-Platform-Control / aerpaw-portal

AERPAW Portal v2
0 stars 1 forks source link

Both Initiate Development and Submit to Testbed turn green after a failed deployment #41

Closed MagrethMushi1 closed 1 year ago

MagrethMushi1 commented 1 year ago

I noticed that both buttons are available after a failed deployment see screenshot

image

mjstealey commented 1 year ago

Per discussion the logic will enable the submit to testbed button after any successful deployment session is registered for that experiment

def check_submit_to_testbed(experiment: AerpawExperiment):
    """
    Experiment has completed at least one successful development cycle at any point in time
    - TODO: consider checking for most recent development session being successful
    """
    # TODO: define checks for submit to testbed
    session_obj = ExperimentSession.objects.filter(
        experiment_id=experiment.id,
        session_type=ExperimentSession.SessionType.DEVELOPMENT.value,
        start_date_time__isnull=False,
        started_by__isnull=False,
        end_date_time__isnull=False,
        ended_by__isnull=False
    ).order_by('-created').first()
    if session_obj:
        return True
    else:
        return False
mjstealey commented 1 year ago

logic updated to be more explicit and deployed