AElfProject / AElf

An AI-enhanced cloud-native layer-1 blockchain network. 
https://aelf.com/
MIT License
1.61k stars 265 forks source link

Extend seed NFT expiration time #3624

Open JimAelf opened 1 week ago

JimAelf commented 1 week ago

Ability to allow the owner of the SEED Collection to extend the expiration time for the specified SEED NFT. For issue #3622

vizipi[bot] commented 1 week ago

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% jason-hoopox 29 4
100.00% ZhangXin 18 4
100.00% gldeng 13 4
100.00% zhifenglee-portkey 2 4
75.00% eanzhao 41 3
75.00% chopin.fan 3 3

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/token_contract.proto91.30%21 out of 23 times
...contract/AElf.Contracts.Election/ElectionContract_Elector91.30%21 out of 23 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio91.30%21 out of 23 times
...test/AElf.Contracts.EconomicSystem.Tests/BVT/TreasuryBasi91.30%21 out of 23 times
contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs86.96%20 out of 23 times
contract/AElf.Contracts.Economic/EconomicContract.cs86.96%20 out of 23 times
contract/AElf.Contracts.MultiToken/TokenContractState.cs82.61%19 out of 23 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT82.61%19 out of 23 times
...contract/AElf.Contracts.CrossChain/CrossChainContract_Hel82.61%19 out of 23 times
test/AElf.Contracts.TestBase/ContractTester.cs82.61%19 out of 23 times

Committed file ranks

  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 99.12%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 97.83%[protobuf/token_contract_impl.proto]
  • 99.13%[...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe]
  • codecov[bot] commented 1 week ago

    Codecov Report

    Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

    Project coverage is 73.31%. Comparing base (88d4e10) to head (1404c3e).

    Files with missing lines Patch % Lines
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 70.83% 7 Missing :warning:

    :exclamation: There is a different number of reports uploaded between BASE (88d4e10) and HEAD (1404c3e). Click for more details.

    HEAD has 21 uploads less than BASE | Flag | BASE (88d4e10) | HEAD (1404c3e) | |------|------|------| ||31|10|
    Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AElfProject/AElf/pull/3624/graphs/tree.svg?width=650&height=150&src=pr&token=X07fSKQJPV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject)](https://app.codecov.io/gh/AElfProject/AElf/pull/3624?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) ```diff @@ Coverage Diff @@ ## dev #3624 +/- ## =========================================== - Coverage 90.53% 73.31% -17.23% =========================================== Files 677 677 Lines 26104 26128 +24 Branches 2353 2355 +2 =========================================== - Hits 23634 19155 -4479 - Misses 2355 6820 +4465 - Partials 115 153 +38 ``` | [Flag](https://app.codecov.io/gh/AElfProject/AElf/pull/3624/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/AElfProject/AElf/pull/3624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/AElfProject/AElf/pull/3624?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) | Coverage Δ | | |---|---|---| | [...AElf.Contracts.MultiToken/TokenContract\_Actions.cs](https://app.codecov.io/gh/AElfProject/AElf/pull/3624?src=pr&el=tree&filepath=contract%2FAElf.Contracts.MultiToken%2FTokenContract_Actions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject#diff-Y29udHJhY3QvQUVsZi5Db250cmFjdHMuTXVsdGlUb2tlbi9Ub2tlbkNvbnRyYWN0X0FjdGlvbnMuY3M=) | `72.34% <70.83%> (-22.31%)` | :arrow_down: | ... and [149 files with indirect coverage changes](https://app.codecov.io/gh/AElfProject/AElf/pull/3624/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject)

    🚨 Try these New Features: