search

AElfProject / aelf-web3.js

aelf JavaScript SDK
MIT License
16 stars 24 forks source link

fix: 🐛 sha256 incorrect in google chrome #123

Closed potter-sun closed 1 year ago

potter-sun commented 1 year ago

Google Chrome 115.0.5790.102 produces incorrect SHA-256 hashes

When js-sha256 is used in chrome, there will be occasional problems in generating hash. Refer to the following method to use @aws-crypto/sha256-js

reference link： https://github.com/emn178/js-sha256/issues/40

vizipi[bot] commented 1 year ago

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % AbigailDeng 57 14
28.57 % lhoopox 2 4

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold

Committed file ranks

  • 98.79%[yarn.lock]
  • 0.00%[src/index.js]
  • 97.57%[dist/aelf.umd.js]
  • 0.00%[test/e2e/wallet.test.js]
  • 68.02%[src/util/bloom.js]
  • 80.97%[src/util/utils.js]
  • 95.95%[dist/aelf.cjs.js.map]
  • 99.60%[package.json]
  • 97.57%[dist/aelf.cjs.js]
  • 95.95%[test/unit/chain/index.test.js]