AElfProject / aelf-web3.js

aelf JavaScript SDK
MIT License
16 stars 24 forks source link

fix: 🐛 transformArrayToMap fieldsArray may undefined #129

Closed lhoopox closed 1 year ago

lhoopox commented 1 year ago

Parsing can be problematic when the contract result contains an array of enumerated types

vizipi[bot] commented 1 year ago

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % AbigailDeng 23 7
57.14 % potter-sun 5 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
test/unit/chain/chainMethod.test.js50.00 %1 out of 2 times
package.json50.00 %1 out of 2 times
src/util/utils.js50.00 %1 out of 2 times
test/unit/chain/index.test.js50.00 %1 out of 2 times
test/unit/util/merkleTree.test.js50.00 %1 out of 2 times
test/unit/util/bloom.test.js50.00 %1 out of 2 times
test/unit/contract/contractMethod.test.js50.00 %1 out of 2 times
types/contract/contractMethod.d.ts50.00 %1 out of 2 times
test/unit/contract/index.test.js50.00 %1 out of 2 times
README.md50.00 %1 out of 2 times

Committed file ranks

  • 97.64%[dist/aelf.umd.js]
  • 66.93%[src/util/transform.js]
  • 92.52%[test/unit/util/transform.test.js]
  • 97.64%[dist/aelf.cjs.js]
  • 80.71%[test/unit/util/token.proto.json]
  • 96.46%[dist/aelf.cjs.js.map]
  • 96.46%[dist/aelf.umd.js.map]