Tick Loop (AE2)

[Shadowhunter82]

Hello Found ah new bug!

http://pastebin.com/7SddPEni

[Speiger]

@Shadowhunter82 when did that happen? When your AESystem did craft something?

[Shadowhunter82]

Thats the main problem i don´t know, It happend on my server. and there are ah view people on it with the autocrafting from AE

[Speiger]

Test it in singelplayer. or make a server on your pc on put the mods in and try to crash it with this bug.

[iTitus]

AE2 is throwing the CraftEvent but with a null-Playerobject, @AEnterprise should implement a null-Check there.

Am 07.09.2014 um 17:18 schrieb Speiger notifications@github.com:

Test it in singelplayer. or make a server on your pc on put the mods in and try to crash it with this bug.

— Reply to this email directly or view it on GitHub.

[Speiger]

@iTitus i did think that too but could be possible that the fakeplayer of them had some problems.

[iTitus]

Trying to reproduce now

[iTitus]

Ok, its definetely a broken FakePlayer: the playerNetServerHandler is null while it tries to send a message in "addChatMessage(IChatComponent)"

[AEnterprise]

@iTitus so this has to be reported to AE2 then? should i do a null check for that?

[iTitus]

Yes, I think so, I was able to recreate this with only AE2, BC6 and BCA. When I created the right amount of Tools via Autocrafting it crashed with the same crash log.

[iTitus]

You could check if player.playerNetServerHandler is null before sending a message but this should be done at AE2's end, I think

[AEnterprise]

the right amount, so did you make progresss if you look in your book?

[iTitus]

I will check now, I have to restart MC

[iTitus]

My Player did not make any progress. But it keeps crashing as long as the crafting operation is running (I requested 60 Wooden Pickaxes...)

[BigXplosion]

You should just add a null check like iTitus said, but you can't really blame AE2 (and other mods that can cause this problem) for this, as I don't think there is a better way of throwing a CraftEvent without having a normal player.

[AEnterprise]

alright will add a null check

[BigXplosion]

Also it's normal that auto crafting stuff via AE2 or other mods doesn't progress the player as there is no player specified. the same thing is happening for the HQM quest if you have a crafting task, only the player crafted items help you progress.

[AEnterprise]

did it with a try catch as there might be other issues with fake players, this will take care of all of them

[iTitus]

Also a possible solution ;)

[Speiger]

Why not make a FakePlayerTestfunction?

[AEnterprise]

@Speiger this just prevent all possible crashes, easier solution and it works