AEnterprise / Eureka

Learning as you go
GNU Lesser General Public License v3.0
13 stars 4 forks source link

"EUREKA!" Spam In Chat #32

Closed fcpwiz closed 9 years ago

fcpwiz commented 9 years ago

After updating to 3.0, the text "EUREKA!" spams the chat about every 20 seconds.

O13SC3N3 commented 9 years ago

Yep, problem still exist.

fcpwiz commented 9 years ago

Is this actually going to get "fixed"?

AEnterprise commented 9 years ago

@fcpwiz what do you mean by 'in chat'? in your in game chat or in the game console?

also why are you asking if this is gona actually get fixed? of course i'm gona fix it but you only opened this issue 6 hours ago when i was sleeping, i didn't had the chanse to reply yet

fcpwiz commented 9 years ago

Yeah this only happens in the chat. It doesn't show up in the console.

AEnterprise commented 9 years ago

you sure you have eureka 3.0 downloaded from curseforge?

fcpwiz commented 9 years ago

Yes

fcpwiz commented 9 years ago

I'm using Eureka-1.7.10-3.0.jar

AEnterprise commented 9 years ago

so it's every 20 sec? you sure it's 20 sec and not each time you do something?

fcpwiz commented 9 years ago

It's actually very random. http://i.imgur.com/p1adf8o.png

fcpwiz commented 9 years ago

Oh wait. Every time I hit "E" it prints "EUREKA!"

AEnterprise commented 9 years ago

@fcpwiz now that makes more sense, now i know what it is i can fix it

fcpwiz commented 9 years ago

After further examination, it looks like "EUREKA!" Shows up when:

jermangarc commented 9 years ago

Yup got this same issue as well, every time I open up my inventory.

fcpwiz commented 9 years ago

@jermangarc Yeah. Hope there will be a fix soon. All players on my server are going haywire about it. Haha

AEnterprise commented 9 years ago

could you guys try in singleplayer and see if the issue is also pressent then?

fcpwiz commented 9 years ago

Looks like it doesn't occur in single player. Odd.

AEnterprise commented 9 years ago

just what i thought, the problem lies in the research syncing code, in singleplayer client and server are the same so some things work then and not in multiplayer

fcpwiz commented 9 years ago

Ok. When are we expecting a fix? :)

AEnterprise commented 9 years ago

will do my best to fix this over the weekend and do a release

fcpwiz commented 9 years ago

great! thanks man

fcpwiz commented 9 years ago

Awesome! Thanks for the fix! When are you planning on releasing this version?

AEnterprise commented 9 years ago

today or tomorow, got a few other bugs to squach

fcpwiz commented 9 years ago

Ok. Now looking at the changes you made, I can't seem to find the line that prints "EUREKA!" Where is it?

AEnterprise commented 9 years ago

it is here: https://github.com/AEnterprise/Eureka/commit/04b30b896a5ebdbdb3d75fffb0e297c8adb54793#diff-0729800cbb7ac429bfe41f3510226d45R49

the issue was that the server was trying to send the message but errored when trying to localize the title

fcpwiz commented 9 years ago

I mean the old line that you had to delete to remove it from saying "EUREKA!"

AEnterprise commented 9 years ago

the lines linked to replace that, the old line was removed and instead it sends a message to the client telling it to print out the message

fcpwiz commented 9 years ago

ah ok! nice work!

AEnterprise commented 9 years ago

eureka 3.0.1 released

fcpwiz commented 9 years ago

Awesome! Where can I download it? It's not showing up on curse forge for me.

AEnterprise commented 9 years ago

check on curseforge again in a few mins, uploaded it but curse hasn't aproved the file yet

AEnterprise commented 9 years ago

@fcpwiz file is available now