AEnterprise / Eureka

Learning as you go
GNU Lesser General Public License v3.0
13 stars 4 forks source link

Eureka book won't go on bibliocraft shelves #39

Open jacfalcon0 opened 9 years ago

jacfalcon0 commented 9 years ago

Started my personal modpack and it spawned several books from several mods, and I was able to put all of them on my Bibliocraft bookshelf except for the "Engineering Diary" set up by Eureka. I don't have any other Eureka books so I don't know if it's universal.

AEnterprise commented 9 years ago

it's odd it is an itemBook so i don't know what the requirement is for an item to go intro the bookshelf

jacfalcon0 commented 9 years ago

Maybe a comparison with Chromaticraft, Tinkers Construct, Withery, etcs book codes would reveal the answer?

On Tue, May 26, 2015, 7:01 AM AEnterprise notifications@github.com wrote:

it's odd it is an itemBook so i don't know what the requirement is for an item to go intro the bookshelf

— Reply to this email directly or view it on GitHub https://github.com/AEnterprise/Eureka/issues/39#issuecomment-105534835.

AEnterprise commented 9 years ago

yeah i'll take a look at that later

asl97 commented 9 years ago

imo, since they didn't prove any kind of api (that i could find) or state the requirement for the bookshelf to accept a book and that they got some asset for other mod, i think it's their side.

they did state in their about page about some config options though

Compatibility with mods is also a concern for all blocks involved in this mod. To ease that I added several config options to easily add compatibility to many items.

cc: @Nuchaz

Voxel-Friend commented 9 years ago

Confirmed. To fix, add diary to the list of acceptable books in the bibliocraft config. example These are the keywords that are compared against the item names to determine if the item can be placed on a Bookcase. Add more keywords if needed. S:AllowedBooks=book, map, journal, plan, thaumonomicon, necronomicon, lexicon, print, notes, spell, library, tome, encyclopedia, diary

Voxel-Friend commented 9 years ago

Proof 2015-07-08_15 56 57

hron84 commented 9 years ago

Maybe it should help if you just rename the item to Engineering Notes, since notes already in the list by default. But maybe - just maybe - it's a BiblioCraft enhancement issue, so I recommend you to ask @Nuchaz if there is a way to provide an API to ask bookshelves to accept your book. I definitely want to see this book on my bookshelf too :-)

Anyway, @Voxel-Friend 's workaround should be enough until this get fix from any side.