search

AF-1 / lms-dynamicplaylists

Dynamic Playlists - a plugin for Lyrion Music Server that lets you use smart playlists (dynamic playlists) to play continuous music mixes based on your selection criteria.
GNU General Public License v3.0
17 stars 3 forks source link

Change strictly above to above and equal on PlaylistMin*Tracks #1

Closed werdeil closed 2 years ago

werdeil commented 2 years ago

Hi @AF-1, I again come across the fact that I had 99,8% of album played and yet none on the unplayed album dynamic playlist. While digging a little deeper, I found that the missing ones were albums with only one track.

The issue comes from the fact that you limited PlaylistMinAlbumTracks and PlaylistMinAlbumTracks values to min 1 and use a strictly above on the SQL requests. I changed on the SQL part instead of allowing a min value at 0 as I think it is easier to understand.

AF-1 commented 2 years ago

BTW I think I remember you suggesting/offering a FR translation of localizable strings for DPL3? If you still want that please let me know so I can include it in the next update (together with this commit).

werdeil commented 2 years ago

Yes I'm on it, you shall get it before this week-end I'm testing it right now and checking these are well displayed.