AF-1 / lms-dynamicplaylists

Dynamic Playlists - a plugin for Lyrion Music Serve. Use smart playlists (dynamic playlists) to play continuous music mixes based on your selection criteria.
GNU General Public License v3.0
17 stars 3 forks source link

Every first Custom DPL usage fails, using Material-Skin playlist via browser and then Custom DPL #8

Closed the-other-martin closed 1 year ago

the-other-martin commented 1 year ago

DESCRIBE THE BUG

I'm using several different custom DPLs successfully, e.g. below one for "Lieblingstitel". Every first attempt to start Custom DPL after playing Material-Skin built in playlist "Stilrichtung" fails. Second attempt with any other Custom DPL works as expected.



TO REPRODUCE

Steps to reproduce the behavior:

  1. Coming from Material-Skin built in playlist "Genre"/"Stilrichtung" (selected through Material-Skin V3.03: "Meine Musik"/"Stilrichtung") - player (e.g. Squeezebox Touch) is playing as expected.

  2. First usage of Custom DPL : After selecting "Play" for the Custom DPL (see example above) in material skin dialog box showing "Play" but without any other information - Custom DPL doesn't start.

  3. Selecting "Play" for any other Custom DPL after first fail works as expected: dialog box is showing up with "Starting dynamic playlist: xxxxxxxxx" and Custom DPL plays as expected.After selecting "Play" for the Custom DPL (see example above) in material skin dialog box showing "Play" but without any other information - Custom DPL doesn't start.



EXPECTED BEHAVIOR

Even the first usage of Custom DPL after using Material-Skin built in playlist "Stilrichtung" should start the selected Custom DPL and play.



LOG EXCERPT

n/a



NAME/CODE OF DYNAMIC PLAYLIST

-- PlaylistName:03 Lieblingstitel
-- PlaylistGroups: Custom Dynamic Playlists
select tracks.id, tracks.primary_artist from tracks
    join genre_track on
        tracks.id=genre_track.track
    join genres on
        genre_track.genre=genres.id
    left join dynamicplaylist_history on
        tracks.id=dynamicplaylist_history.id and dynamicplaylist_history.client='PlaylistPlayer'
    where
        audio=1
        and dynamicplaylist_history.id is null
        and genres.name not like '%(%)%'
        and genres.name not like 'Alternative%'
        and genres.name not like 'Blues%'
        and genres.name not like 'Boogie%'
        and genres.name not like 'Books & Spoken%'
        and genres.name not like 'Cabaret%'
        and genres.name not like 'Children''s Music%'
        and genres.name not like 'Christmas%'
        and genres.name not like 'Classical%'
        and genres.name not like 'Country%'
        and genres.name not like 'Deutsch%'
        and genres.name not like 'Dixie%'
        and genres.name not like 'Dub%'
        and genres.name not like 'Ethno%'
        and genres.name not like 'Industrial%'
        and genres.name not like 'Jazz%'
        and genres.name not like 'Kabarett%'
        and genres.name not like 'Metal%'
        and genres.name not like 'Operette%'
        and genres.name not like 'Schlager%'
        and genres.name not like 'Soundtrack%'
        and genres.name not like 'Tanzmusik%'
        and genres.name not like 'Techno%'
        and genres.name not like 'Volksmusik%'
    group by tracks.id
    order by random()
    limit 30;



VERSION INFO



SCREENSHOTS

If applicable, add screenshots to help explain your problem. grafik First usage: grafik Second usage (with other Custom DPL) grafik Playing as expected: grafik Playing same playlist as in first try successfully: grafik



ADDITIONAL CONTEXT

n/a



UPLOADS

n/a

AF-1 commented 1 year ago

EDIT: I think I found the bug. On it.

The Play notification in Material is just Material confirming the selection you made from a list of options (Play, Add, ...). That's why there's nothing else in that message. That's unrelated to the bug.

P.S. I use DPL for 'Dynamic Playlists' (the plugin) and dpl for dynamic playlist(s), the actual playlist(s). Confusing, I know :-)

AF-1 commented 1 year ago

Should be fixed in 4.0.4. Before I close this, I'd appreciate a brief confirmation that the problem no longer occurs in 4.0.4. Thank you.

the-other-martin commented 1 year ago

You are a LMS hero! After latest update to "Dynamic Playlists 4.0.4" the DPL works as expected for my custom dynamic playlists! Many thanks! Martin