search

AF-VCD / pdf-bullets

Web-based utility for writing Air Force Bullets (EPR/OPR/Awards)
MIT License
44 stars 38 forks source link

"undefined" error when importing #24

Closed joze14rock closed 3 years ago

joze14rock commented 4 years ago

When importing my own Excel abbrs list, then imputing bullets, I receive an "undefined" error in the output.

EXAMPLE:

input: aircraft output: acftundefined

Am I importing it wrong?

whurleywhurley commented 4 years ago

Could you post the file you're uploading that has the abbreviations?

joze14rock commented 4 years ago

abbrs.xlsx

Attached. Thank you!

ckhordiasma commented 4 years ago

All right, from my preliminary troubleshooting there seems to be one or more abbreviations in your list that cause the abbreviations system to shit itself. I’ll need to do some more digging in to see which abbreviations are causing the issue and fix the abbreviations system accordingly.

On Wed, Aug 12, 2020 at 19:13 joze14rock notifications@github.com wrote:

abbrs.xlsx https://github.com/AF-VCD/pdf-bullets/files/5066388/abbrs.xlsx

Attached. Thank you!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AF-VCD/pdf-bullets/issues/24#issuecomment-673154626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53AMQ6BHHZKXPF5TTMRTLSAMO3FANCNFSM4P3DVDJA .

ckhordiasma commented 4 years ago

Ok, on further examination you have several abbreviations like annual(ly) -> ann(ly) and that is causing the problem.

So there are a couple of issues.

First, right now my abbreviations system can't handle parentheses on the left side, and it's causing that undefined to show up. This is a bug that I can probably fix.

Second, the abbreviations list is not smart enough to parse the parentheses into two abbreviations, annual->ann and annually->annly. As a workaround for this, you should make two separate entries for annual and annually. I might make this a new feature but I gotta think carefully about how to implement it without more bugs.

joze14rock commented 4 years ago

Sounds good! I'll scrub my abbrv list. Thank you!

ckhordiasma commented 3 years ago

fixed in ad7a5f5c656b537cdda0943a99449d2b88a80e58 , will close issue when pulled from my branch (https://ckhordiasma.github.io/pdf-bullets/) into main af-vcd code.

ckhordiasma commented 3 years ago

forgot to close this once I merged the fix