AF-VCD / pdf-bullets

Web-based utility for writing Air Force Bullets (EPR/OPR/Awards)
MIT License
44 stars 38 forks source link

172 i's should fit on one line of an AF1206 #34

Closed ckhordiasma closed 3 years ago

ckhordiasma commented 3 years ago

iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii

I'm glad nobody has called me out on this, which means that it's not that prevalent or common of an issue.

The above line of 172 i's will fit on a 1206, but won't fit in one line on the bullet tool. This tells me that there is a slight but unacceptable discrepancy between my tool and actual PDFs.

I want to get this fixed, but it will likely involve significant refactoring of the bullet optimization subcomponents. Creating an issue here so I don't forget.

ckhordiasma commented 3 years ago

Initial implementation of fix is now in my test branch, see renderBulletText() and Bullet()

https://github.com/ckhordiasma/pdf-bullets/commit/a968186b38447088e46349422a8e3e853ab39b5f

ckhordiasma commented 3 years ago

implemented 060fc135f960bac78b7bdcad292e3b379bf137b9