AFCP / forumhorizonchine

fork of forumhorizonchine
0 stars 3 forks source link

Latest changes in production #21

Closed antoineol closed 10 years ago

antoineol commented 10 years ago

Before deploying your application in production, there are some differences with the current production website that must be corrected. When it's done, you can deploy the website in production (default app version: 1).

lutianming commented 10 years ago
antoineol commented 10 years ago

Could you define French as default language as well please? We are based in France and the association is Franco-Chinese, so I don't think the English version should be the default one. Also put the French flash first in the list of flags. When it's done, I may add a new "issue" (improvement) to save the language choice in cookies.

lutianming commented 10 years ago

OK

2013/12/16 architruc notifications@github.com

Could you define French as default language as well please? We are based in France and the association is Franco-Chinese, so I don't think the English version should be the default one.

— Reply to this email directly or view it on GitHubhttps://github.com/lutianming/forumhorizonchine/issues/21#issuecomment-30699254 .

antoineol commented 10 years ago
lutianming commented 10 years ago

2013/12/16 architruc notifications@github.com

  • English homepage: "ENSTA ParisTech on March 6, 2014 ." There is a space between 2014 and the dot that should be removed. There are also differences between the chinese versions (production versus your website). I don't know which one is better so I let you choose, but you should have a look at this, particularly this section at the bottom: "您是巴黎高科的学生或毕业生?"
  • (I changed the job enterprises order to match the production order)
  • http://lutianming.forumhorizonchine.appspot.com/visitors/workpermitEnglish title: "you wish to send a comment about this guide?" Could you change the first word "You" with an uppercase first letter?

    http://lutianming.forumhorizonchine.appspot.com/visitors/about/contactThe textarea doesn't exactly match the one in production. Could you

  • NEW: the menu on the left hasn't the same labels in the chinese version (ex: 展出商). Did you fix a mistake? and "关于论坛" is also a new category title.

    http://lutianming.forumhorizonchine.appspot.com/visitors/about/contactin chinese: a space is missing for "朱琪先生" (between 朱琪 and 先生) or remove all spaces in the table to be coherent.

— Reply to this email directly or view it on GitHubhttps://github.com/lutianming/forumhorizonchine/issues/21#issuecomment-30700663 .

antoineol commented 10 years ago

production code:

The attribute rows="5" fix the height.

Well, thanks for your work. The website can now be deployed to production. Could you also deploy the old version with another app version? And last but not least: the admin password should be changed before deploying, in both production and qualification versions, since the datastore is shared. Please let me know as soon as it's done.