AFD-Illinois / iharm3d

Hybrid MPI/OpenMP 3D HARM with vectorization
Other
12 stars 9 forks source link

Feature/electron models #38

Closed vedantdhruv96 closed 3 years ago

vedantdhruv96 commented 3 years ago

Touched up the PR by @blancocd.

What's new:

bprather commented 3 years ago

I like this way of doing things, but note that if we ever change the order of KEL values, it will break any subsequent imaging work in ipole -- thus we should add them to the output spec here.

To make my life easier when trying to image all these options in ipole, can we bump the version in decs.h to "iharm-alpha-3.7"? That way we'll be able to distinguish easily what ordering to use when trying to read electron temperatures.

(Honestly we should have the master branch using "release" or at least "beta" to distinguish, but that's for another time.)