AFD-Illinois / ipole

Polarized covariant radiative transport code
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

critical: bug in stepsize for non-MKS models #55

Closed gnwong closed 3 years ago

gnwong commented 3 years ago

Christian Fromm identified a bug in the way the i-suite calculates stepsize: stepsize assumes X2 is bounded above by 1. See the relevant ipole line of code here:

https://github.com/AFD-Illinois/ipole/blob/63b2aa7b216bfe6ec16cbec46de0cce9ccf6986b/src/model_geodesics.c#L57

Perhaps the most correct way to deal with this is to include stepsize in the model files and (in the iharm model) explicitly load x2_max, since there's nothing in the iharm file format that forces x2_max == 1.

bprather commented 3 years ago

This is fixed in dev: https://github.com/AFD-Illinois/ipole/blob/dev/src/model_geodesics.c#L208

I fixed it specifically to implement bhac_mks coordinates

gnwong commented 3 years ago

The circle closes!