search

AFD-Illinois / ipole

Polarized covariant radiative transport code
16 stars 12 forks source link

add isothermal sphere model #59

Closed gnwong closed 3 years ago

gnwong commented 3 years ago

This PR adds the "isothermal sphere" model to ipole. The model comprises a sphere with uniform density, uniform Theta_e, and a uniform vertical magnetic field.

Before merging, we should address: 1) the definition of Thetae_unit, 2) whether or not to add model parameters to output h5 image, 3) whether or not the regular parameter parsing works (should work but has not been tested extensively), 4) whether or not to include exponential radial (minkowski) coordinates to speed up integrations far from the hole.

bprather commented 3 years ago

I am happy to merge this as is, but I would love 2 regression tests to be built on this at some point:

  1. Thermal image of this model at some moderately difficult set of parameters
  2. Kappa image of this model with same

Bonus points if (2) is directly comparable to a result run at least once with some other kappa implementation. I think these shouldn't be too bad to add to the current set, and won't increase the download size of ipole testing data by much since the underlying model is analytic.

As for the points mentioned, I think (2) should probably get added before merge. Otherwise I don't think the current commit needs changes unless you want to.