Closed Marcondiro closed 6 days ago
I'll rebase on this before making libafl_qemu changes in #2438.
What's the benefit of the perf-event-open-sys crate thingy over bindgen? Just double checking / asking stupid questions :)
No worries :)
It has a couple of syscall/ioctl wrappers already available and it
addresses an issue I had with Bindgen and #define
s. They solved it
already in their wrapper.h
adding an enum.
Let me know if you want me to go deeper than this answer :D
Nah sounds good, it's just always good to double-check if new crates are necessary. If it solves issues let's gooo
If we're to release 0.14 soon, can we merge (part of) this PR already? At least the stuff that changes existing APIs would probably be good to have
@domenukk yep sure, I will clean up the code a bit and let you know when it is reviewable
Hello @rmalmain @domenukk, if you wish you could start to have a look at the new code in libafl_bolts (interface to intelPT usable in both libafl and libafl_qemu) and at the IntelPT executor hook. Also the babyfuzzer should be kinda ready.
I'm still working on cleaning the commandExecutor (and the fuzzer built on top of it), it might be removed from this PR depending on the 0.14 cutoff date thanks!
Can you merge main?
I am waiting for this https://github.com/AFLplusplus/LibAFL/pull/2652 to be reverted...
Also, any chance we can merge this today or tomorrow for 0.14?
@domenukk I think I've addressed every comment
ok on my side. let's merge @domenukk ?
Again to the bitbybit, I am not against it at all, but we shoudn't have two dependencies for the same use case - so we need to change the other usage to bitbybit
Great work btw! :)
WIP, any feedback is welcome