AFLplusplus / LibAFL

Advanced Fuzzing Library - Slot your Fuzzer together in Rust! Scales across cores and machines. For Windows, Android, MacOS, Linux, no_std, ...
Other
2.03k stars 319 forks source link

DrCovModule is exclusive to user-mode #2572

Closed vringar closed 1 month ago

vringar commented 1 month ago

The issue exists in 17def039

Describe the bug

Previously the QemuDrCovHelper could be used in Systemmode and was critical to the way we worked.

2267 moved the DrCovModule into the usermode module making it inaccessible for our usecase.

To Reproduce Steps to reproduce the behavior:

  1. Look where drcov.rs is in the tree
  2. See the conditional inclusion of this module

Expected behavior

I expect this module to be available in systemmode as well.

Additional context

I'm sorry if there is a technical reason why this only works in usermode, I'll move the DrCovModule to the generic modules and see what happens. However, I still wanted to open the issue, so maybe you can tell me, why I shouldn't do this.

rmalmain commented 1 month ago

sorry, it's a mistake on my end. I'll fix asap

vringar commented 1 month ago

Thank you so much!

rmalmain commented 1 month ago

no worries, thanks for pointing out the issue! once the ci is happy i'll merge the patch