search

AFM-SPM / TopoStats

An AFM image analysis program to batch process data and obtain statistics from images
https://afm-spm.github.io/TopoStats/
GNU Lesser General Public License v3.0
60 stars 11 forks source link

Ability to set image_set for filters, grains and tracing separately to reduce output #958

Open llwiggins opened 4 weeks ago

llwiggins commented 4 weeks ago

Users flagged that the new updates to DNA tracing significantly increase the amount of outputs produced when image_set: all is set in the config file. It was agreed that as all output images have potential to be useful for parameter refining, rather than reduce the output it would be better to have the option to set whether core or all should be output for filters, grains and tracing separately.

ns-rse commented 4 weeks ago

@llwiggins @SylviaWhittle @MaxGamill-Sheffield @alicepyne

This feels like this is something that needs addressing before merging and making a release, do you agree?

Regardless, what should the defaults be with regards to setting core / all for each stage of filters / grains / tracing ?

alicepyne commented 4 weeks ago

I think defaults to core but would say that separating these can wait until the next smaller release to avoid scope creep in this one

On Wed, 16 Oct 2024 at 12:11, Neil Shephard @.***> wrote:

@llwiggins https://github.com/llwiggins @SylviaWhittle https://github.com/SylviaWhittle @MaxGamill-Sheffield https://github.com/MaxGamill-Sheffield @alicepyne https://github.com/alicepyne

This feels like this is something that needs addressing before merging and making a release, do you agree?

Regardless, what should the defaults be with regards to setting core / all for each stage of filters / grains / tracing ?

— Reply to this email directly, view it on GitHub https://github.com/AFM-SPM/TopoStats/issues/958#issuecomment-2416495685, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJSFMKLJDTBETOF2IGB2LLZ3ZCXBAVCNFSM6AAAAABQA6LXHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJWGQ4TKNRYGU . You are receiving this because you were mentioned.Message ID: @.***>

SylviaWhittle commented 4 weeks ago

With how urgent this is to merge (so reviewers can verify the code works) this could be done after a merge I think? It would be preferable to do beforehand aye but I believe the priority currently is that reviewers are able to run the code from main?

ns-rse commented 4 weeks ago

It will be useful to set some clear Milestones for the coming months work to prioritise the backlog of issues and what needs addressing first (and clear out the existing Milestones!).