Various video services fix and added e2e testing

AFP-Medialab / verification-plugin

A verification “Swiss army knife” helping journalists, fact-checkers, and human rights defenders to save time and be more efficient in their fact-checking and debunking tasks on social networks especially when verifying videos and images

23 stars 2 forks source link

Various video services fix and added e2e testing #552

Open twinkarma opened 3 weeks ago

twinkarma commented 3 weeks ago

Added e2e testing for various image and video posts including their available services
Allow services to pick from input type (original url entered in the assistant search) or the process type (the url of the media that is scraped). This is because most media is now served from a CDN and it's more useful to identify the source of the media by the input links instead.
Twitter: Disabled video analysis, keyframe and video rights services
Instagram: Disabled embedding, and keyframe
Dailymotion: remove keyframe service
Vimeo: remove keyframe service
Disable video embedding for urls starting with blob:
Add a service to tell users that videos can be manually uploaded to Weverify to access more analyis services
- Give instructions to TikTok users that videos can be downloaded easily by going to the post's page

twinkarma commented 1 week ago

I'm aware that the PR is becoming quite large so will stop here.

Sallaa commented 1 week ago

I will have a look next week. I browsed the changes quickly and saw that you added an icon. Could you use MUI's icon instead? You can use the Download or FileDownload icon from MUI for instance. Link to the documentation This will help to keep styling consistent.

Side note, we have a few custom icons we use, and in case you really need one, you can have a look at what I recently did for the tools refactoring in the tools.jsx file (in beta-master). Basically I wrapped each icon in an SvgIcon component which allows to have the same styling flexibility as MUI icons. We will eventually refactor all the other custom icons in the plugin to SvgIcons too.

twinkarma commented 1 week ago

There are some icons that don't have a direct equivalent like the keyframes or the forensic icon. Do you have a guideline on what you plan to be using?

twinkarma commented 1 week ago

I've made it optional so that both the image file and svg can be used for now with the intention of replacing all the icons to svg eventually.

Sallaa commented 6 days ago

Sorry @twinkarma I think my message was confusing, if there is no equivalent, feel free to use a custom SVG (SVG being better than JPEG because we can embed it in an MUI component and have consistent styling).