Fix iPhone X Max, XS Max, 11Pro Max size recording size problem.

AFathi / ARVideoKit

Capture & record ARKit videos 📹, photos 🌄, Live Photos 🎇, and GIFs 🎆.

Apache License 2.0

1.62k stars 226 forks source link

Fix iPhone X Max, XS Max, 11Pro Max size recording size problem. #106

Closed 0k1019 closed 4 years ago

0k1019 commented 4 years ago

Fix iPhone X Max, XS Max, 11Pro Max size recording size problem. Renewing "isiPhone10" extension to "isNotch".

I have a problem in recording Max device. The record video size was 1080x1920. So i fix the problem. Check my code.

GiacomoLeopizzi commented 4 years ago

Hello! Checking the .bottom maybe exclude the detection when the iPhone is in landscape. A better approach, in my opinion, would be to check if safeAreaInsets are equal to .zero. Let me know your opinion 😃

Giacomo

0k1019 commented 4 years ago

Thanks for comment. Giacomo. I understand what you consider. I didn't consider landscape.
I make another PR.

Young.