Open adambrown1 opened 1 year ago
I think it's a nice idea to put a fail-safe option in control nodes when it doesn't receive new data for too long. For the alarms, I'm not so sure. A pipeline goes 'stale' when it doesn't receive new data from one of the input sensors -> put an alarm on the sensor. You want to know if you ran out of nitrogen -> Put an alarm on the scale. We can discuss offline
The fail-safe option should also activate when a node produces an exception, then I agree that your solution solves point 1 & 2. Should also be used when the pipeline is stopped -> solves point 3.
To point 4, this is fair enough for the dewar level, what about the alarm when a LN2 valve has been open for too long?
I think we should add a way to handle problems which occur when pipelines are controlling critical systems. For example, if a pipeline controls LN2 refill and there is no new level value for a long time, we should probably stop filling to avoid disaster (and maybe issue an alarm). One idea might be to add the following functionality (but maybe someone has better ideas)