AG-Schumann / doberview2

A NodeJS-based web frontend for Doberman v6
GNU General Public License v3.0
1 stars 0 forks source link

Cannot delete pipeline document entries #23

Closed adambrown1 closed 1 year ago

adambrown1 commented 1 year ago

It is impossible to unset entries using the mongo update command, so entries cannot be removed from the pipeline documents in the database. This would make it impossible, for example, to unset min_output of an AnalogControlNode, which is the documented way to disable that function.

Maybe the update should become a replaceOne, and use the _id entry rather than name to reference it. This would also allow pipelines to be renamed as per issue #16. https://github.com/AG-Schumann/doberview2/blob/7a3f65aee8a16320ae9e442fb28cba307e3b5909/routes/pipeline.js#L61

Somewhat related to this: when modifying an existing pipeline the confirmation message is still that a new pipeline was added. This should probably get changed at the same time. https://github.com/AG-Schumann/doberview2/blob/7a3f65aee8a16320ae9e442fb28cba307e3b5909/routes/pipeline.js#L65