search

AG-Schumann / doberview2

A NodeJS-based web frontend for Doberman v6
GNU General Public License v3.0
2 stars 0 forks source link

Silence rework #46

Closed jarongrigat closed 1 year ago

jarongrigat commented 1 year ago

Works with experimental branch of doberman. Solves #28

adambrown1 commented 1 year ago

How does reactivating work -- is this still by sending a command to the pipeline or should the silent_until database entry be updated (or is this a comment for the doberman PR?)

adambrown1 commented 1 year ago

Somewhat related to this PR: can we get rid of the constraints on silencing pipelines at the same time? A couple of times I have, for example, wanted to silence a pipeline early in the morning (or in the night) until 5 pm, but my request has been rejected by doberview. Or on Thursday, silence until Monday. It just leads to people silencing forever, and I don't think it really gives us any extra protection.

jarongrigat commented 1 year ago

How does reactivating work -- is this still by sending a command to the pipeline or should the silent_until database entry be updated (or is this a comment for the doberman PR?)

This is done in doberman (i.e. pipeline_activate command to hypervisor sets silent_until to now. Maybe for consistency, we should do everything via Doberman...

jarongrigat commented 1 year ago

Somewhat related to this PR: can we get rid of the constraints on silencing pipelines at the same time? A couple of times I have, for example, wanted to silence a pipeline early in the morning (or in the night) until 5 pm, but my request has been rejected by doberview. Or on Thursday, silence until Monday. It just leads to people silencing forever, and I don't think it really gives us any extra protection.

Sure.

adambrown1 commented 1 year ago

How does reactivating work -- is this still by sending a command to the pipeline or should the silent_until database entry be updated (or is this a comment for the doberman PR?)

This is done in doberman (i.e. pipeline_activate command to hypervisor sets silent_until to now. Maybe for consistency, we should do everything via Doberman...

OK, whether everything is done in Doberman or not is not so critical from my perspective.