All buttons available for pipelines in sensor dropdown menu

[TiffanyLuce]

Issue #51 In the sensor dropdown menu, in the Pipelines section : the "Go to" button has been removed and silencing/activating and restarting buttons have been added to relevant pipelines.

[TiffanyLuce]

Corrected the cilencing button such that it shows the time dropdown menu and silences for the wanted duration. It is however an easy and ugly fix in my opinion because I had to copy paste two existing functions from pipeline.js. I thought I could use function accross js files but I guess it depends when each of them are loaded? I anyhow didn't find how to change this. There is for sure a better way to do it.

Regarding the silence silent pipelines, I think Jaron is working on the silence rework where this would be implemented so I don't know if it is essential to find a olution until then.

[jarongrigat]

Corrected the cilencing button such that it shows the time dropdown menu and silences for the wanted duration. It is however an easy and ugly fix in my opinion because I had to copy paste two existing functions from pipeline.js. I thought I could use function accross js files but I guess it depends when each of them are loaded? I anyhow didn't find how to change this. There is for sure a better way to do it.

Haha now I remember that this is exactly why I didn't do it in the first place. Didn't figure out fast enough how too make it not ugly and hoped nobody will complain about clicking one extra button. Well, here we are. I can have a look next week.

[jarongrigat]

Regarding the silence silent pipelines, I think Jaron is working on the silence rework where this would be implemented so I don't know if it is essential to find a olution until then.

Yes, this is already done. Just has to be done together with Doberman update. Again, next week.

[adambrown1]

Corrected the cilencing button such that it shows the time dropdown menu and silences for the wanted duration. It is however an easy and ugly fix in my opinion because I had to copy paste two existing functions from pipeline.js. I thought I could use function accross js files but I guess it depends when each of them are loaded? I anyhow didn't find how to change this. There is for sure a better way to do it.

Regarding the silence silent pipelines, I think Jaron is working on the silence rework where this would be implemented so I don't know if it is essential to find a olution until then.

The javascript file has to actually be included in the page, for the full_systems page for example this is done here https://github.com/AG-Schumann/doberview2/blob/cdfb385e8e7b4fa16621102b7f001f307b4c2348/views/full_system.pug#L4

You could put the relevant functions in default_scripts.js which is loaded by default https://github.com/AG-Schumann/doberview2/blob/cdfb385e8e7b4fa16621102b7f001f307b4c2348/views/index.pug#L18

[adambrown1]

Regarding the silence silent pipelines, I think Jaron is working on the silence rework where this would be implemented so I don't know if it is essential to find a olution until then.

Thanks, if this is coming soon anyway do we want to foresee having the button available anyway?

[jarongrigat]

😟