search

AG-Schumann / doberview2

A NodeJS-based web frontend for Doberman v6
GNU General Public License v3.0
1 stars 0 forks source link

Remove special valve handling code for control #69

Closed adambrown1 closed 11 months ago

adambrown1 commented 11 months ago

Closes #66

Valves are no longer handled as a special case, they are just status sensors with is_int: 1 and a suitable value mapping.

This conveniently means that many of what we previously called valves (pumps etc.) now have more sensible labels (On / Off, for example)

adambrown1 commented 11 months ago

Is it possible to change it so that it works also with statuses that are integers but not set as is_int=1 (because it is not for xebra ): ) ? Even though they are not set as is int, statuses should always be integers anyway right ?

I dunno if that is always true, can we not just set is_int =1 in XeBRA too for consistency?

jarongrigat commented 11 months ago

We should probably delete the ToggleValve() function in default_scripts since it's not used anymore